Getting into a punctuation disagreement with The New Yorker is probably about as good an idea as getting involved in a land war in Asia, but…
I thought you hyphenate a noun–adjective phrase when it functions as an attributive adjective, but not a predicate adjective.